Hmm... I think:
'Hij is (een) Nederlands leraar' means he is a male teacher, who teaches the subject Dutch, and same goes for 'hij is (een) leraar Nederlands' (een can be omitted). Neither of them states the nationality of the teacher. Nederlands is the subject they teach.
If you said:
'Hij is een Nederlandse leraar'
the nationality is stated by the word 'Nederlandse'