Search from various English teachers...
Italy flagMarco
Did or Have made? Is it more correct to say: "Did you make the tea/coffee/cake?" or "Have you made the tea/coffee/cake?". Or maybe both sentences are good? Thanks

Corrections · 9

2

Did or Have made?

Hello Marco,

I think it is more natural to say 'Have you made the tea?' as you are expecting a result in the present (A cup of tea!) 'Did you make the tea' is more distant in time and would be natural with a past qualifier. 'Did you make the tea yesterday?'


Hope this helps


Bob

1

Did or Have made?

Is it more correct to say:

"Did you make the tea/coffee/cake?" or "Have you made the tea/coffee/cake?". Or maybe both sentences are good?

Thanks

The previous comments are correct. However, these are high minded distinctions that one might consider when writing a thesis. For casual speech by an educated adult asking about tea, either question is absolutely correct and they both have the same meaning for English speakers.

1

Did or Have made?

Is it more correct to say:

"Did you make the tea/coffee/cake?" or "Have you made the tea/coffee/cake?". Or maybe both sentences are good?

Thanks


Did you make is a past tense.   

Have you made is a present perfect simple i.e. a past action that is finished with a result in the present (the tea was done and now is ready).  Though I do rather say Have you done the tea?

0
Interesting explanation! I'll consider both ways, Thank you April :)
0
Both sentences are correct and very similar. I would maybe choose one over the other for the following reasons. "Did you make the tea/coffee/cake?" - asking did you make it yes or no. "Have you made the tea/coffee/cake?" - there is a suggestion that the person you are asking is intending to make it and you are checking to see if they have completed that task. I hope that's helpful. :)

Want to progress faster?

Join this learning community and try out free exercises!

Don’t miss out on the opportunity to learn a language from the comfort of your own home. Browse our selection of experienced language tutors and enroll in your first lesson now!

Start Learning Today