In my high school, we had the choice of Spanish, French, or German. Probably, 80% chose Spanish, 15% chose French., probably 5% chose German.
It was not required for high school graduation, but was required for anyone who wanted to go to college.
I chose German, partly because I had a German exchange teacher in 6th grade and partly because I didn't want to do what everyone else was doing.
I did not learn much. I do not think I even reached the A2 level.
But, the results were pretty much the same for all languages. I only know a very small handful of non-native speakers who can converse in Spanish. I work as an eligibility specialist and must take several calls from clients daily. I do not think any my co-workers who are not native Spanish speakers can take calls in Spanish. Either native speakers handle such calls or we use an interpreting service.
I think it makes little sense to talk about which foreign languages U.S. students should learn, given how few reach any meaningful proficiency.
The reality is that for most Americans, foreign language will always be a hobby. It is great for the mind and really broadens one's horizons. But, most Americans do not have any absolute need for any foreign language, including Spanish or Chinese. In fact, for many people, it is very hard to find opportunities offline. All the native speakers of these languages that I speak to regularly speak fluent English. In fact, those born in the U.S. often speak English better than their heritage language.
But, then again, I would say the same for English for much of the world's population.